Compare commits
3 Commits
5ff972ebcb
...
94297e75b9
| Author | SHA1 | Date |
|---|---|---|
|
|
94297e75b9 | |
|
|
ff09d1b89a | |
|
|
4fa147282f |
|
|
@ -53,7 +53,7 @@ public class SamplingRateRepository {
|
|||
EntityManager em = entityManagerFactory.createEntityManager();
|
||||
try{
|
||||
SamplingRate samplingRate = em.find(SamplingRate.class, id);
|
||||
return Optional.of(samplingRate);
|
||||
return Optional.ofNullable(samplingRate);
|
||||
}finally {
|
||||
if (em.isOpen()) em.close();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -32,14 +32,21 @@ public class SamplingRateService {
|
|||
}
|
||||
|
||||
public Optional<SamplingRate> getSamplingRateById(Integer id) {
|
||||
if (id == null) {
|
||||
throw new IllegalArgumentException("ID cannot be null");
|
||||
}
|
||||
logger.info("Getting sampling rate by id:{}", id);
|
||||
return repository.findById(id);
|
||||
}
|
||||
|
||||
public Optional<SamplingRate> updateSamplingRate(Integer id, String value) {
|
||||
if (id == null) {
|
||||
throw new IllegalArgumentException("ID cannot be null");
|
||||
}
|
||||
logger.info("Updating sampling rate:{}", value);
|
||||
if (value == null || value.trim().isEmpty()) {
|
||||
throw new IllegalArgumentException("Sampling-Rate value cannot be null or empty");}
|
||||
throw new IllegalArgumentException("Sampling-Rate value cannot be null or empty");
|
||||
}
|
||||
Optional<SamplingRate> existingSamplingRate = repository.findById(id);
|
||||
if(existingSamplingRate.isEmpty()) {
|
||||
logger.warn("Sampling rate not found with id:{}", id);
|
||||
|
|
@ -52,6 +59,9 @@ public class SamplingRateService {
|
|||
}
|
||||
|
||||
public boolean deleteSamplingRate(Integer id) {
|
||||
if (id == null) {
|
||||
throw new IllegalArgumentException("Sampling rate id cannot be null");
|
||||
}
|
||||
logger.info("Deleting sampling rate:{}", id);
|
||||
return repository.deleteById(id);
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue