Compare commits

...

5 Commits

Author SHA1 Message Date
Gustavo Henrique Miranda fecb0288d3
Merge pull request #12 from gmbrax/feature/auto-handler-scanner
Feature/auto handler scanner
2025-11-29 20:37:26 -03:00
Gustavo Henrique Santos Souza de Miranda 5ce8f4ca2a Improve `DelegateActionManager` error handling for invalid handlers
- Add validation to ensure classes annotated with `@Action` implement `ActionHandler`, throwing `IllegalArgumentException` for mismatches.
- Fix minor formatting issue in `@Action` annotation for `GetGenreByIdHandler`.
2025-11-29 15:33:08 -03:00
Gustavo Henrique Miranda a5bd6e2c39
Update src/main/java/com/mediamanager/service/delegate/DelegateActionManager.java
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-11-29 09:52:54 -03:00
Gustavo Henrique Santos Souza de Miranda f87d6b1b53 Refactor `DelegateActionManager` for dynamic handler registration
- Replace manual handler registration with automatic scanning and registration of handlers annotated with `@Action`.
- Introduce `ServiceLocator` to enable dependency injection for dynamically instantiated handlers.
- Add `initializeServices` to centralize service initialization and registration.
- Enhance error handling and logging for handler instantiation and registration processes.
2025-11-29 08:26:58 -03:00
Gustavo Henrique Santos Souza de Miranda b715bb1bd3 Add `@Action` annotation and `ServiceLocator` for improved handler registration
- Introduce `@Action` annotation to simplify action handler identification and tagging.
- Add `ServiceLocator` for dynamic service registration and retrieval.
- Annotate handlers (`CreateGenreHandler`, `GetGenreHandler`, `UpdateGenreHandler`, `DeleteGenreHandler`, etc.) with corresponding actions.
2025-11-29 07:54:46 -03:00
11 changed files with 215 additions and 17 deletions

View File

@ -3,46 +3,59 @@ package com.mediamanager.service.delegate;
import com.google.protobuf.ByteString; import com.google.protobuf.ByteString;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.repository.GenreRepository; import com.mediamanager.repository.GenreRepository;
import com.mediamanager.service.delegate.handler.CloseHandler; import com.mediamanager.service.delegate.annotation.Action;
import com.mediamanager.service.delegate.handler.EchoHandler;
import com.mediamanager.service.delegate.handler.HeartbeatHandler;
import com.mediamanager.service.delegate.handler.genre.*;
import com.mediamanager.service.genre.GenreService; import com.mediamanager.service.genre.GenreService;
import jakarta.persistence.EntityManagerFactory; import jakarta.persistence.EntityManagerFactory;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
import org.reflections.Reflections;
import org.reflections.scanners.Scanners;
import java.lang.reflect.Constructor;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import java.util.Set;
public class DelegateActionManager { public class DelegateActionManager {
private static final Logger logger = LogManager.getLogger(DelegateActionManager.class); private static final Logger logger = LogManager.getLogger(DelegateActionManager.class);
private final Map<String, ActionHandler> handlerRegistry; private final Map<String, ActionHandler> handlerRegistry;
private final ServiceLocator serviceLocator;
private final EntityManagerFactory entityManagerFactory; private final EntityManagerFactory entityManagerFactory;
private final GenreService genreService;
public DelegateActionManager(EntityManagerFactory entityManagerFactory) { public DelegateActionManager(EntityManagerFactory entityManagerFactory) {
this.entityManagerFactory = entityManagerFactory; this.entityManagerFactory = entityManagerFactory;
this.serviceLocator = new ServiceLocator();
initializeServices();
GenreRepository genreRepository = new GenreRepository(entityManagerFactory);
this.genreService = new GenreService(genreRepository);
logger.debug("DelegateActionManager created"); logger.debug("DelegateActionManager created");
this.handlerRegistry = new HashMap<>(); this.handlerRegistry = new HashMap<>();
registerHandlers(); autoRegisterHandlers();
} }
private void registerHandlers() { private void initializeServices() {
handlerRegistry.put("echo",new EchoHandler()); logger.info("Initializing services...");
handlerRegistry.put("heartbeat",new HeartbeatHandler());
handlerRegistry.put("close", new CloseHandler());
handlerRegistry.put("create_genre", new CreateGenreHandler(genreService)); GenreRepository genreRepository = new GenreRepository(entityManagerFactory);
handlerRegistry.put("get_genres", new GetGenreHandler(genreService)); GenreService genreService = new GenreService(genreRepository);
handlerRegistry.put("get_genre_by_id", new GetGenreByIdHandler(genreService));
handlerRegistry.put("update_genre", new UpdateGenreHandler(genreService));
handlerRegistry.put("delete_genre", new DeleteGenreHandler(genreService)); serviceLocator.register(GenreService.class, genreService);
serviceLocator.logRegisteredServices();
logger.info("Services initialized successfully");
} }
public void start(){ public void start(){
logger.info("DelegateActionManager started"); logger.info("DelegateActionManager started");
} }
@ -51,6 +64,117 @@ public class DelegateActionManager {
logger.info("DelegateActionManager stopped"); logger.info("DelegateActionManager stopped");
} }
@SuppressWarnings("unchecked")
private ActionHandler instantiateHandler(Class<?> clazz) throws Exception {
if(!ActionHandler.class.isAssignableFrom(clazz)){
throw new IllegalArgumentException(
clazz.getName() + " is annotated with @Action but does not implement ActionHandler");
}
logger.debug("Attempting to instantiate handler: {}", clazz.getSimpleName());
Constructor<?>[] constructors = clazz.getDeclaredConstructors();
// Sort constructors by parameter count (descending) to prefer DI constructors
java.util.Arrays.sort(constructors, (c1, c2) ->
Integer.compare(c2.getParameterCount(), c1.getParameterCount()));
for (Constructor<?> constructor : constructors) {
Class<?>[] paramTypes = constructor.getParameterTypes();
Object[] params = new Object[paramTypes.length];
boolean allDependenciesResolved = true;
for (int i = 0; i < paramTypes.length; i++) {
Object service = serviceLocator.get(paramTypes[i]);
if (service == null) {
allDependenciesResolved = false;
logger.debug("Cannot resolve dependency {} for {}",
paramTypes[i].getSimpleName(),
clazz.getSimpleName());
break; // Para de tentar esse construtor
}
params[i] = service;
}
if (allDependenciesResolved) {
logger.debug("Using constructor with {} params for {}",
paramTypes.length, clazz.getSimpleName());
return (ActionHandler) constructor.newInstance(params);
}
}
throw new IllegalStateException(
String.format(
"Cannot instantiate handler %s. No suitable constructor found. " +
"Make sure all required services are registered in ServiceLocator.",
clazz.getName()
)
);
}
private void autoRegisterHandlers() {
logger.info("Starting auto-registration of handlers...");
Reflections reflections = new Reflections(
"com.mediamanager.service.delegate.handler",
Scanners.TypesAnnotated
);
Set<Class<?>> annotatedClasses = reflections.getTypesAnnotatedWith(Action.class);
logger.info("Found {} handler classes with @Action annotation", annotatedClasses.size());
int successCount = 0;
int failureCount = 0;
for (Class<?> handlerClass : annotatedClasses) {
try {
Action actionAnnotation = handlerClass.getAnnotation(Action.class);
String actionName = actionAnnotation.value();
logger.debug("Processing handler: {} for action '{}'",
handlerClass.getSimpleName(),
actionName);
ActionHandler handler = instantiateHandler(handlerClass);
handlerRegistry.put(actionName, handler);
logger.info("✓ Registered handler: '{}' -> {}",
actionName,
handlerClass.getSimpleName());
successCount++;
} catch (Exception e) {
logger.error("✗ Failed to register handler: {}",
handlerClass.getName(),
e);
failureCount++;
}
}
logger.info("Auto-registration complete: {} successful, {} failed, {} total",
successCount,
failureCount,
successCount + failureCount);
if (failureCount > 0) {
logger.warn("Some handlers failed to register. Check logs above for details.");
}
}
public TransportProtocol.Response ProcessedRequest(TransportProtocol.Request request){ public TransportProtocol.Response ProcessedRequest(TransportProtocol.Request request){
String requestId = request.getRequestId(); String requestId = request.getRequestId();
logger.info("Processing request: {}", requestId); logger.info("Processing request: {}", requestId);

View File

@ -0,0 +1,45 @@
package com.mediamanager.service.delegate;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import java.util.HashMap;
import java.util.Map;
public class ServiceLocator {
private static final Logger logger = LogManager.getLogger(ServiceLocator.class);
private final Map<Class<?>, Object> services = new HashMap<>();
public <T> void register(Class<T> serviceClass, T serviceInstance) {
if (serviceInstance == null) {
throw new IllegalArgumentException("Service instance cannot be null");
}
services.put(serviceClass, serviceInstance);
logger.debug("Registered service: {} -> {}",
serviceClass.getSimpleName(),
serviceInstance.getClass().getSimpleName());
}
@SuppressWarnings("unchecked")
public <T> T get(Class<T> serviceClass) {
return (T) services.get(serviceClass);
}
public boolean has(Class<?> serviceClass) {
return services.containsKey(serviceClass);
}
public int size() {
return services.size();
}
public void logRegisteredServices() {
logger.info("Registered services: {}", services.size());
services.forEach((clazz, instance) ->
logger.info(" - {} -> {}",
clazz.getSimpleName(),
instance.getClass().getSimpleName())
);
}
}

View File

@ -0,0 +1,13 @@
package com.mediamanager.service.delegate.annotation;
import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
public @interface Action {
String value();
}

View File

@ -6,9 +6,11 @@ import com.mediamanager.protocol.TestProtocol.CloseCommand;
import com.mediamanager.protocol.TestProtocol.CloseResponse; import com.mediamanager.protocol.TestProtocol.CloseResponse;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
@Action("close")
public class CloseHandler implements ActionHandler { public class CloseHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(CloseHandler.class); private static final Logger logger = LogManager.getLogger(CloseHandler.class);

View File

@ -6,9 +6,11 @@ import com.mediamanager.protocol.TestProtocol.EchoCommand; // ← Import
import com.mediamanager.protocol.TestProtocol.EchoResponse; // Import import com.mediamanager.protocol.TestProtocol.EchoResponse; // Import
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
@Action("echo")
public class EchoHandler implements ActionHandler { public class EchoHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(EchoHandler.class); private static final Logger logger = LogManager.getLogger(EchoHandler.class);

View File

@ -6,9 +6,11 @@ import com.mediamanager.protocol.TestProtocol.HeartbeatCommand;
import com.mediamanager.protocol.TestProtocol.HeartbeatResponse; import com.mediamanager.protocol.TestProtocol.HeartbeatResponse;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
@Action("heartbeat")
public class HeartbeatHandler implements ActionHandler { public class HeartbeatHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(HeartbeatHandler.class); private static final Logger logger = LogManager.getLogger(HeartbeatHandler.class);

View File

@ -7,10 +7,12 @@ import com.mediamanager.model.Genre;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.protocol.messages.GenreMessages; import com.mediamanager.protocol.messages.GenreMessages;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import com.mediamanager.service.genre.GenreService; import com.mediamanager.service.genre.GenreService;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
@Action("genre.create")
public class CreateGenreHandler implements ActionHandler { public class CreateGenreHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(CreateGenreHandler.class); private static final Logger logger = LogManager.getLogger(CreateGenreHandler.class);

View File

@ -5,10 +5,12 @@ import com.google.protobuf.InvalidProtocolBufferException;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.protocol.messages.GenreMessages; import com.mediamanager.protocol.messages.GenreMessages;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import com.mediamanager.service.genre.GenreService; import com.mediamanager.service.genre.GenreService;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
@Action("genre.delete")
public class DeleteGenreHandler implements ActionHandler { public class DeleteGenreHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(DeleteGenreHandler.class); private static final Logger logger = LogManager.getLogger(DeleteGenreHandler.class);

View File

@ -7,12 +7,14 @@ import com.mediamanager.model.Genre;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.protocol.messages.GenreMessages; import com.mediamanager.protocol.messages.GenreMessages;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import com.mediamanager.service.genre.GenreService; import com.mediamanager.service.genre.GenreService;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
import java.util.Optional; import java.util.Optional;
@Action("genre.getById")
public class GetGenreByIdHandler implements ActionHandler { public class GetGenreByIdHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(GetGenreByIdHandler.class); private static final Logger logger = LogManager.getLogger(GetGenreByIdHandler.class);

View File

@ -7,12 +7,14 @@ import com.mediamanager.model.Genre;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.protocol.messages.GenreMessages; import com.mediamanager.protocol.messages.GenreMessages;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import com.mediamanager.service.genre.GenreService; import com.mediamanager.service.genre.GenreService;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
import java.util.List; import java.util.List;
@Action("genre.getAll")
public class GetGenreHandler implements ActionHandler { public class GetGenreHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(GetGenreHandler.class); private static final Logger logger = LogManager.getLogger(GetGenreHandler.class);

View File

@ -7,12 +7,14 @@ import com.mediamanager.model.Genre;
import com.mediamanager.protocol.TransportProtocol; import com.mediamanager.protocol.TransportProtocol;
import com.mediamanager.protocol.messages.GenreMessages; import com.mediamanager.protocol.messages.GenreMessages;
import com.mediamanager.service.delegate.ActionHandler; import com.mediamanager.service.delegate.ActionHandler;
import com.mediamanager.service.delegate.annotation.Action;
import com.mediamanager.service.genre.GenreService; import com.mediamanager.service.genre.GenreService;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
import java.util.Optional; import java.util.Optional;
@Action("genre.update")
public class UpdateGenreHandler implements ActionHandler { public class UpdateGenreHandler implements ActionHandler {
private static final Logger logger = LogManager.getLogger(UpdateGenreHandler.class); private static final Logger logger = LogManager.getLogger(UpdateGenreHandler.class);