Fix broken removeGenre to correct logic for the null-pointer exception

Fix broken removeGenre to avoid possible null-pointer
Fix broken removeGenre implementation in Album entity
2026-11-09 22:10:17 +00:00 · 2025-12-08 00:37:05 -03:00 · 2025-12-08 00:33:23 -03:00 · 2025-12-08 00:22:42 -03:00 · 2025-12-08 00:16:02 -03:00 · 2025-12-08 00:14:51 -03:00
1 changed files with 10 additions and 3 deletions
@@ -74,7 +74,9 @@ public class Album {

    public void removeArtist(Artist artist) {
        albumArtists.removeIf(aa ->
-                aa.getArtist() != null && aa.getArtist().getId().equals(artist.getId())
+                aa.getArtist() != null && 
+                aa.getArtist().getId() != null && 
+                aa.getArtist().getId().equals(artist.getId())
        );
    }

@@ -96,8 +98,13 @@ public class Album {
    }

    public void removeGenre(Genre genre) {
+        if (genre == null) {
+            return;
+        }
        albumGenres.removeIf(ag ->
-                ag.getGenre() != null && ag.getGenre().getId().equals(genre.getId())
+                ag.getGenre() != null &&
+                        ag.getGenre().getId() != null &&
+                        ag.getGenre().getId().equals(genre.getId())
        );
    }
Author	SHA1	Message	Date
Gustavo Henrique Santos Souza de Miranda	8119530bef	Fix broken removeGenre to correct logic for the null-pointer exception	2025-12-08 00:37:05 -03:00
Gustavo Henrique Santos Souza de Miranda	09d20efba6	Fix broken removeGenre to avoid possible null-pointer	2025-12-08 00:33:23 -03:00
Gustavo Henrique Santos Souza de Miranda	bcd03fc7ce	Fix broken removeGenre implementation in Album entity	2025-12-08 00:22:42 -03:00
Gustavo Henrique Miranda	d70fae0719	Merge pull request #23 from gmbrax/feature/Implement-Album-Management Implement Album management with full CRUD operations	2025-12-08 00:16:02 -03:00
Gustavo Henrique Miranda	9e3516aacb	Enhance genre removal logic in Album class Update removeGenre method to check for null IDs.	2025-12-08 00:14:51 -03:00
Gustavo Henrique Mirandaandcoderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>	7b7d1e7348	Update src/main/java/com/mediamanager/model/Album.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>	2025-12-08 00:11:47 -03:00
Gustavo Henrique Miranda	dccbfcf546	Merge pull request #22 from gmbrax/feature/Implement-AlbumType-Management Implement AlbumType management with full CRUD operations	2025-12-07 20:09:01 -03:00