Add fixture and tests for the backup service

src/pilgrim/models/entry.py

@@ -1,6 +1,5 @@
-from typing import Any, List
+from typing import Any
 
-from pilgrim.models.photo import Photo
 from pilgrim.models.photo_in_entry import photo_entry_association
 from sqlalchemy import Column, Integer, String, ForeignKey, DateTime
 from sqlalchemy.orm import relationship
@@ -22,12 +21,9 @@ class Entry(Base):
     fk_travel_diary_id = Column(Integer, ForeignKey("travel_diaries.id"), nullable=False)
     travel_diary = relationship("TravelDiary", back_populates="entries")
 
-    def __init__(self, title: str, text: str, date: Any, travel_diary_id: int, photos: List[Photo] = None, **kw: Any):
+    def __init__(self, title: str, text: str, date: str, travel_diary_id: int, **kw: Any):
         super().__init__(**kw)
         self.title = title
         self.text = text
         self.date = date
         self.fk_travel_diary_id = travel_diary_id
-        if photos is not None:
-            self.photos = photos
-

tests/conftest.py

@@ -1,13 +1,15 @@
-from datetime import datetime
+from pathlib import Path
+from unittest.mock import patch
 
 import pytest
 from sqlalchemy import create_engine
 from sqlalchemy.orm import sessionmaker
 
-from pilgrim.models.entry import Entry
 from pilgrim.database import Base
 from pilgrim.models.travel_diary import TravelDiary
 from pilgrim.models.photo import Photo
+from pilgrim.utils import DirectoryManager
+
 
 # Todos os imports necessários para as fixtures devem estar aqui
 # ...
@@ -67,21 +69,36 @@ def session_with_photos(session_with_one_diary):
     return session, [photo1, photo2]
 
 @pytest.fixture
-def entry_with_photo_references(session_with_one_diary):
+def backup_test_env_files_only(tmp_path):
-    session, diary = session_with_one_diary
+    fake_config_dir = tmp_path / "config"
-    photo1 = Photo(filepath="p1.jpg", name="P1", photo_hash="aaaaaaaa", fk_travel_diary_id=diary.id)
+    fake_diaries_root = tmp_path / "diaries"
-    photo2 = Photo(filepath="p2.jpg", name="P2", photo_hash="bbbbbbbb", fk_travel_diary_id=diary.id)
+    fake_db_path = fake_config_dir / "database.db"
-    session.add_all([photo1, photo2])
+    fake_config_dir.mkdir()
-    session.flush()
+    fake_diaries_root.mkdir()
-    entry = Entry(
+    with patch.object(DirectoryManager, 'get_database_path', return_value=fake_db_path), \
-        title="Entrada com Fotos",
+            patch.object(DirectoryManager, 'get_config_directory', return_value=fake_config_dir), \
-        text="Texto com a foto A [[photo::aaaaaaaa]] e também a foto B [[photo::bbbbbbbb]].",
+            patch.object(DirectoryManager, 'get_diaries_root', return_value=fake_diaries_root):
-        date=datetime.now(),
+        engine = create_engine(f"sqlite:///{fake_db_path}")
-        travel_diary_id=diary.id,
+        Base.metadata.create_all(engine)
-        photos=[photo1, photo2]
+        Session = sessionmaker(bind=engine)
-    )
+        session = Session()
-    session.add(entry)
+
-    session.commit()
+        diary = TravelDiary(name="Viagem de Teste", directory_name="viagem_de_teste")
-    session.refresh(entry)
+        session.add(diary)
+        session.commit()
+        photo_file_path_str = str(fake_diaries_root / "viagem_de_teste" / "images" / "foto1.jpg")
+        photo = Photo(filepath=photo_file_path_str, name="Foto 1", photo_hash="hash123", fk_travel_diary_id=diary.id)
+        session.add(photo)
+        session.commit()
+        photo_file_path = Path(photo_file_path_str)
+        photo_file_path.parent.mkdir(parents=True)
+        photo_file_path.touch()
+        yield {
+            "session": session,
+            "db_path": fake_db_path,
+            "config_dir": fake_config_dir,
+            "diaries_root": fake_diaries_root,
+        }
+        session.close()
+
 
-    return session, entry

tests/service/test_backup_service.py

@@ -0,0 +1,39 @@
+import zipfile
+from pathlib import Path
+from unittest.mock import patch, MagicMock
+from pilgrim.service.backup_service import BackupService
+from pilgrim.utils.directory_manager import DirectoryManager
+import pytest
+
+@patch.object(DirectoryManager, 'get_diaries_root')
+@patch.object(DirectoryManager, 'get_config_directory')
+@patch.object(DirectoryManager, 'get_database_path')
+def test_create_backup_success(mock_get_db_path, mock_get_config_dir, mock_get_diaries_root, backup_test_env_files_only):
+    env = backup_test_env_files_only
+    session = env["session"]
+    mock_get_db_path.return_value = env["db_path"]
+    mock_get_config_dir.return_value = env["config_dir"]
+    mock_get_diaries_root.return_value = env["diaries_root"]
+
+    service = BackupService(session)
+    backup_zip_path = env["config_dir"] / "backup.zip"
+    success, returned_path = service.create_backup()
+    assert success is True
+    assert returned_path == backup_zip_path
+    assert backup_zip_path.exists()
+
+    with zipfile.ZipFile(backup_zip_path, 'r') as zf:
+        file_list = zf.namelist()
+        assert "database.sql" in file_list
+        assert "diaries/viagem_de_teste/images/foto1.jpg" in file_list
+        sql_dump = zf.read("database.sql").decode('utf-8')
+        assert "Viagem de Teste" in sql_dump
+
+@patch.object(DirectoryManager, 'get_database_path')
+def test_create_backup_fails_if_db_not_found(mock_get_db_path, tmp_path: Path):
+    non_existent_db_path = tmp_path / "non_existent.db"
+    mock_get_db_path.return_value = non_existent_db_path
+    mock_session = MagicMock()
+    service = BackupService(mock_session)
+    with pytest.raises(FileNotFoundError, match="No Database Found"):
+        service.create_backup()

tests/service/test_entry_service.py

@@ -261,46 +261,3 @@ def test_delete_returns_none_if_entry_does_not_exist(db_session):
     non_existent_entry.id = 999
     result = service.delete(non_existent_entry)
     assert result is None
-
-def test_delete_references_for_specific_photo(entry_with_photo_references):
-    session, entry = entry_with_photo_references
-    service = EntryService(session)
-    updated_entry = service.delete_references_for_specific_photo(entry, "aaaaaaaa")
-    assert "[[photo::aaaaaaaa]]" not in updated_entry.text
-    assert "[[photo::bbbbbbbb]]" in updated_entry.text
-
-def test_delete_specific_photo_reference_does_nothing_if_no_match(entry_with_photo_references):
-    session, entry = entry_with_photo_references
-    service = EntryService(session)
-
-    original_text = entry.text
-    updated_entry = service.delete_references_for_specific_photo(entry, "cccccccc")
-    assert updated_entry.text == original_text
-
-def test_delete_all_photo_references_removes_all_refs(entry_with_photo_references):
-    session, entry = entry_with_photo_references
-    service = EntryService(session)
-    updated_entry = service.delete_all_photo_references(entry)
-    assert "[[photo::aaaaaaaa]]" not in updated_entry.text
-    assert "[[photo::bbbbbbbb]]" not in updated_entry.text
-
-def test_delete_all_photo_references_uses_truncated_hash(session_with_one_diary):
-    session, diary = session_with_one_diary
-    service = EntryService(session)
-    long_hash_photo = Photo(
-        filepath="long.jpg", name="Long",
-        photo_hash="1234567890abcdef",  # Hash com 16 caracteres
-        fk_travel_diary_id=diary.id
-    )
-    entry = Entry(
-        title="Teste de Hash Curto",
-        text="Referência com hash truncado [[photo::12345678]].",  # Texto usa só os 8 primeiros
-        date=datetime.now(),
-        travel_diary_id=diary.id
-    )
-    entry.photos.append(long_hash_photo)
-    session.add_all([long_hash_photo, entry])
-    session.commit()
-    updated_entry = service.delete_all_photo_references(entry)
-    expected_text = "Referência com hash truncado                   ."
-    assert "[[photo::12345678]]" not in updated_entry.text